Prevent specifying preview stabilization option for unsupported devices #462
+13
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Video stabilization has two modes, ON and PREVIEW_STABILIZATION; the second one gets enabled when enabling preview stabilization which might not be supported on all devices)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps resolve the issue specified at #457
Video stabilization has two modes, ON and PREVIEW_STABILIZATION, rather than preview and video recorder stabilization being two independent options. PREVIEW_STABILIZATION, the relatively newer option across devices gets chosen when preview stabilization is enabled on the Preview, but this may not be available on all devices,
This PR would ensure that PREVIEW_STABILIZATION is opted for only when its available, and otherwise the default ON mode on devices that support video stabilization in general